[libvirt] [PATCH v2] news: Update for 4.8.0 release

Erik Skultety eskultet at redhat.com
Mon Oct 1 11:58:42 UTC 2018


On Mon, Oct 01, 2018 at 12:57:18PM +0200, Fabiano Fidêncio wrote:
> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> ---
> I went through the commits since last release and added a few notes
> which seem to be relevant for the news.
>
> In case you notice there's something missing, please, either send me the
> text to add it (and I'll re-sping this patch) and add the text before
> merging this one.
>
> Changes since v1:
> - Actually run make-check in order to be sure the changes are fine.
> ---
>  docs/news.xml | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 69 insertions(+)
>
> diff --git a/docs/news.xml b/docs/news.xml
> index 3ed6ff8aeb..62148d28af 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -44,6 +44,26 @@
>            and virDomainPMWakeup APIs.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          utils: Introduce monitor capability interface
> +        </summary>
> +        <description>
> +          The resource monitor has been introduces and it creates the interface
> +          for getting the host capability of the resource monitor from the system
> +          resource control.
> +          The resource monitor takes the role of RDT monitoring groups and could
> +          be used to monitor the resource consumption information.
> +        </description>

I think ^this is related to the entry below, so that would IMHO suffice.

> +      </change>
> +      <change>
> +        <summary>
> +          conf: Introduce RDT monitor host capability
> +        </summary>
> +        <description>
> +          Introduce cache monitor (CMT) and memory bandwidth monitor (MBM).
> +        </description>
> +      </change>
>      </section>
>      <section title="Removed features">
>        <change>
> @@ -55,6 +75,15 @@
>            Drop support for these older versions and require Xen >= 4.6.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          nwfilter: Disallow binding creation in session mode
> +        </summary>
> +        <description>
> +          Ensure that a filter binding creation is not attempted in session
> +          mode and generate the proper error message.

s/the proper/a proper

> +        </description>
> +      </change>
>      </section>
>      <section title="Improvements">
>        <change>
> @@ -68,8 +97,48 @@
>            Guest Agent.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          storage: Allow to use any format as input volume for encryption
> +        </summary>
> +        <description>
> +          Since v4.5.0 libvirt has support to use a 'raw' input volume for
> +          encryption. From now on, let's not limit this to 'raw' only.

I'd say:
Libvirt has supported 'raw' input volumes for encryption since 4.5.0. Now, it's
not going to limit the usage to 'raw' only anymore.

> +        </description>
> +      </change>
> +      <change>
> +        <summary>
> +          libxl: Add support to set shadow memory for any guest type
> +        </summary>
> +        <description>
> +          PVH guests now can take advantage of using shadow memory.
> +        </description>
> +      </change>
>      </section>
>      <section title="Bug fixes">
> +      <change>
> +        <summary>
> +          virsh: Require explicit --domain for domxml-to-native
> +        </summary>
> +        <description>
> +          The domxml-to-native virsh command accepts either --xml or --domain
> +          option followed by a file or domain name respectively, The --domain
> +          option is documented as required, which means an argument with no
> +          option is treated as --xml. Commit v4.3.0-127-gd86531daf2 broke this
> +          by making --domain optional and thus an argument with no option was
> +          treated as --domain.

Too verbose, how about:
The --domain option for domxml-to-native virsh command has always been
documented as required, but commit v4.3.0-127-gd86531daf2 accidentally made it
optional.

> +        </description>
> +      </change>
> +      <change>
> +        <summary>
> +          lxc_monitor: Avoid AB / BA lock race
> +        </summary>
> +        <description>
> +          A dealock situation could occur when autostarting a LXC domain 'guest'
> +          due to two threads attempting to take opposing locks while holding
> +          opposing locks (AB BA problem).
> +        </description>
> +      </change>
>      </section>
>    </release>
>    <release version="v4.7.0" date="2018-09-03">

Now, this is just a matter of preference, you did a good job, but I'd probably
also mention the following:
09d35afd2c util: file: introduce VIR_AUTOCLOSE macro to close fd of the file automatic
ally
0396cf5336 virsh: Implement vsh-table to iface-list (basically extending it to
the whole virsh)

your call...with the grammar adjustments mentioned above:
Reviewed-by: Erik Skultety <eskultet at redhat.com>




More information about the libvir-list mailing list