[libvirt] [PATCH v3 2/5] libxl: add support for PVH

[Marek Marczykowski-Górecki]

On Tue, Oct 02, 2018 at 06:54:01PM -0600, Jim Fehlig wrote:
> On 10/2/18 5:02 PM, Marek Marczykowski-Górecki wrote:
> > On Tue, Oct 02, 2018 at 04:50:02PM -0600, Jim Fehlig wrote:
> > > My idea to add this variable for clarity now seems diluted by the need for
> > > the extra ifdef's :-/. Your original approach would avoid them.
> > 
> > This #ifdef is only to mute compiler warning (variable set but unused).
> > If you have a better idea for that, I'd very much like to drop #ifdef
> > here.
> 
> Given the ifdef trickery needed with the extra variable, I think the better
> idea is your original idea :-)
> 
> i == nr_guest_archs - 1

Ok, will rollback to that. But I'll wait for os.machine/os.type opinion.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20181003/2cbc159d/attachment-0001.sig>