[libvirt] [PATCH 00/22] syntax-check: Check misaligned stuff and fix them (batch II)

Shi Lei shi_lei at massclouds.com
Fri Oct 5 13:30:16 UTC 2018


On 2018-10-05 at 17:16, DanielP. Berrangé wrote:
>On Fri, Oct 05, 2018 at 11:11:28AM +0200, Andrea Bolognani wrote:
>> On Fri, 2018-10-05 at 09:31 +0100, Daniel P. Berrangé wrote:
>> > I've looked at clang-format before and it is pretty good. It does not
>> > have ability to quite match our code style, but I don't think that
>> > is a real show stopper. We'd be better off just adapting to one of
>> > the common code styles rather than inventing yet another app todo
>> > code indent analysis.
>>
>> I *strongly* support this idea :)
>
>The other benefit of clang-format is that it can actually fix the code
>automatically, as well as reporting on the problem. Our syntax check
>tool merely reports the problem leaving the developer tedious work to
>fix each problem.
>
>Regards,
>Daniel
>--
>|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
>|: https://libvirt.org -o- https://fstop138.berrange.com :|
>|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| 

Don't know that before. Thanks!
The clang-format is really good and its style could be customized
according to libvirt.

Shi Lei




More information about the libvir-list mailing list