[libvirt] [PATCH v4 2/5] libxl: add support for PVH

Jim Fehlig jfehlig at suse.com
Wed Oct 10 16:30:14 UTC 2018


On 10/9/18 5:04 PM, Marek Marczykowski-Górecki wrote:
> On Tue, Oct 09, 2018 at 04:45:01PM -0600, Jim Fehlig wrote:
>> On 10/7/18 9:39 AM, Marek Marczykowski-Górecki wrote:
>>> @@ -647,6 +669,22 @@ libxlMakeDomBuildInfo(virDomainDefPtr def,
>>>                return -1;
>>>            }
>>>    #endif
>>> +    } else if (pvh) {
>>> +        if (VIR_STRDUP(b_info->cmdline, def->os.cmdline) < 0)
>>> +            return -1;
>>> +        if (VIR_STRDUP(b_info->kernel, def->os.kernel) < 0)
>>> +            return -1;
>>> +        if (VIR_STRDUP(b_info->ramdisk, def->os.initrd) < 0)
>>> +            return -1;
>>> +#ifdef LIBXL_HAVE_BUILDINFO_BOOTLOADER
>>> +        if (VIR_STRDUP(b_info->bootloader, def->os.bootloader) < 0)
>>> +            return -1;
>>> +        if (def->os.bootloaderArgs) {
>>> +            if (!(b_info->bootloader_args =
>>> +                  virStringSplit(def->os.bootloaderArgs, " \t\n", 0)))
>>> +                return -1;
>>> +        }
>>> +#endif
>>
>> This is probably fine, but AFAIK no bootloaders currently support pvh.
>> Juergen is working on support in grub2 but that seems to be a little ways
>> off.
> 
> This is independent of grub2 (which could be set as "kernel"), the
> "bootloader" option here is about a program run _in dom0_ to find the
> kernel to load, instead of providing a path directly (see xl.cfg(5)).

Yes of course. I had grub2 on the mind since I had just talked to Juergen about 
the status.

> Like pygrub. And while I haven't tested it with PVH, I see no reason why
> it shouldn't work.

Yep, agreed. As long as you don't mind poking at VM images in dom0 is should 
just work.

Regards,
Jim




More information about the libvir-list mailing list