[libvirt] [PULL 07/45] hw/timer/sun4v-rtc: Use DeviceState::realize rather than SysBusDevice::init
David Gibson
david at gibson.dropbear.id.au
Tue Oct 23 15:10:48 UTC 2018
On Thu, Oct 18, 2018 at 05:03:44PM -0300, Eduardo Habkost wrote:
> From: Philippe Mathieu-Daudé <f4bug at amsat.org>
>
> Move from the legacy SysBusDevice::init method to using DeviceState::realize.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug at amsat.org>
> Reviewed-by: Thomas Huth <thuth at redhat.com>
> Reviewed-by: Cédric Le Goater <clg at kaod.org>
> Message-Id: <20181002212522.23303-4-f4bug at amsat.org>
> Signed-off-by: Eduardo Habkost <ehabkost at redhat.com>
Reviewed-by: David Gibson <david at gibson.dropbear.id.au>
> ---
> hw/timer/sun4v-rtc.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/hw/timer/sun4v-rtc.c b/hw/timer/sun4v-rtc.c
> index 13be94f8da..4e7f6a1eff 100644
> --- a/hw/timer/sun4v-rtc.c
> +++ b/hw/timer/sun4v-rtc.c
> @@ -63,21 +63,21 @@ void sun4v_rtc_init(hwaddr addr)
> sysbus_mmio_map(s, 0, addr);
> }
>
> -static int sun4v_rtc_init1(SysBusDevice *dev)
> +static void sun4v_rtc_realize(DeviceState *dev, Error **errp)
> {
> + SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
> Sun4vRtc *s = SUN4V_RTC(dev);
>
> memory_region_init_io(&s->iomem, OBJECT(s), &sun4v_rtc_ops, s,
> "sun4v-rtc", 0x08ULL);
> - sysbus_init_mmio(dev, &s->iomem);
> - return 0;
> + sysbus_init_mmio(sbd, &s->iomem);
> }
>
> static void sun4v_rtc_class_init(ObjectClass *klass, void *data)
> {
> - SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
> + DeviceClass *dc = DEVICE_CLASS(klass);
>
> - k->init = sun4v_rtc_init1;
> + dc->realize = sun4v_rtc_realize;
> }
>
> static const TypeInfo sun4v_rtc_info = {
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20181023/c26929ea/attachment-0001.sig>
More information about the libvir-list
mailing list