[libvirt] [PATCH v5 03/13] conf: Introduce a new PCI address extension flag

Yi Min Zhao zyimin at linux.ibm.com
Wed Sep 12 05:27:07 UTC 2018



在 2018/9/11 下午4:37, Andrea Bolognani 写道:
> On Tue, 2018-09-04 at 16:39 +0800, Yi Min Zhao wrote:
> [...]
>> @@ -164,6 +164,7 @@ struct _virDomainDeviceInfo {
>>        * assignment, never saved and never reported.
>>        */
>>       int pciConnectFlags; /* enum virDomainPCIConnectFlags */
>> +    int pciAddressExtFlags; /* enum virDomainPCIAddressExtensionFlags */
> There's a comment right above this that explains how pciConnectFlags
> is only used during address assignment: you should amend it to
> mention pciAddressExtFlags too.
>
> Reviewed-by: Andrea Bolognani <abologna at redhat.com>
>
As your comment on the 1st patch, if we have virPCIDeviceAddress
include a extFlag, why not remove this one?

-- 
Yi Min




More information about the libvir-list mailing list