[libvirt] [libvirt PATCH v2 0/4] Share cgroup code that is duplicated between QEMU and LXC

Fabiano Fidêncio fidencio at redhat.com
Wed Sep 12 08:57:32 UTC 2018


virLXCCgroupSetupBlkioTune() and qemuSetupBlkioCgroup() and
virLXCCgroupSetupCpuTune() and qemuSetupCpuCgroup() are the most similar
functions between QEMU and LXC code.

Let's move their common code to virCgroup.

Mind that the first two patches are basically preparing the ground for
the changes introduced in the last two patches.

changes since v1:
- Michal Privoznik pointed out (as did the `make syntax-check` :-)) that
  we do want to keep src/util independently of the parsing code (thus,
  including "conf/domain_conf.h" in vircgroup.h is not the way to go).
  This has been solved now by partially following Michal's suggestion
  and splitting the structs and functions that would be use in the
  common code to new different files.

Fabiano Fidêncio (4):
  domain_conf: split out virBlkioDevice and virDomainBlkiotune
    definitions
  domain_conf: split out virDomainMemtune and virDomainHugePage
    definitions
  vircgroup: Add virCgroupSetupBlkioTune()
  vircgroup: Add virCgroupSetupMemTune()

 src/Makefile.am          |  1 +
 src/conf/domain_conf.c   | 22 ++++--------
 src/conf/domain_conf.h   | 70 +++----------------------------------
 src/libvirt_private.syms |  2 ++
 src/lxc/lxc_cgroup.c     | 69 ++-----------------------------------
 src/qemu/qemu_cgroup.c   | 61 ++-------------------------------
 src/qemu/qemu_command.c  |  4 +--
 src/util/Makefile.inc.am |  2 ++
 src/util/virblkio.c      | 37 ++++++++++++++++++++
 src/util/virblkio.h      | 52 ++++++++++++++++++++++++++++
 src/util/vircgroup.c     | 74 ++++++++++++++++++++++++++++++++++++++++
 src/util/vircgroup.h     |  7 ++++
 src/util/virmem.h        | 66 +++++++++++++++++++++++++++++++++++
 13 files changed, 259 insertions(+), 208 deletions(-)
 create mode 100644 src/util/virblkio.c
 create mode 100644 src/util/virblkio.h
 create mode 100644 src/util/virmem.h

-- 
2.17.1




More information about the libvir-list mailing list