[libvirt] [PATCH 0/2] tests: Add QEMU 3.0.0 capability tests for s390x

[Bjoern Walk]

John Ferlan <jferlan at redhat.com> [2018-09-21, 07:46AM -0400]:
> 
> 
> On 09/21/2018 01:13 AM, Bjoern Walk wrote:
> > John Ferlan <jferlan at redhat.com> [2018-09-20, 04:30PM -0400]:
> >>
> >>
> >> On 09/20/2018 06:20 AM, Boris Fiuczynski wrote:
> >>> Add capability and domcaps tests for QEMU 3.0.0 on s390x.
> >>>
> >>> Boris Fiuczynski (2):
> >>>   tests: Add capabilities data for QEMU 3.0.0 on s390x
> >>>   tests: domaincaps: Add QEMU 3.0 for s390x
> >>>
> >>>  .../domaincapsschemadata/qemu_3.0.0.s390x.xml |   183 +
> >>>  tests/domaincapstest.c                        |     4 +
> >>>  .../caps_3.0.0.s390x.replies                  | 20530 ++++++++++++++++
> >>>  .../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  2691 ++
> >>>  tests/qemucapabilitiestest.c                  |     1 +
> >>>  5 files changed, 23409 insertions(+)
> >>>  create mode 100644 tests/domaincapsschemadata/qemu_3.0.0.s390x.xml
> >>>  create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.replies
> >>>  create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml
> >>>
> >>
> >> Reviewed-by: John Ferlan <jferlan at redhat.com>
> >> (series)
> >>
> >> and pushed,
> > 
> > Thanks, but just for interest, tracking Reviewed-by and other tags is a
> > thing in libvirt or not?
> > 
> 
> <face-palm> - totally forgot to do that on this series - my apologies...
> I still haven't succumbed to figuring out a way to make the R-B add
> happen automagically.... And our hook only cares to see the S-O-B.

No worries. Normally we review our stuff internally first, so the rev-bys
are added to the upstream patch. For more complex patches I think we
will continue this way.

> To answer the question - there's no "official" tracking. Some people
> still use ACK while others use R-By. It was hard enough to jump the
> hurdle for S-O-B.

Ok, good to know.

-- 
IBM Systems
Linux on Z & Virtualization Development
------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Schönaicher Str. 220, 71032 Böblingen
Phone: +49 7031 16 1819
------------------------------------------------------------------------
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 902 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180921/7e74c6e3/attachment-0001.sig>