[libvirt] [PATCH 0/4] Small changes to virdbus

John Ferlan jferlan at redhat.com
Tue Sep 25 23:44:13 UTC 2018



On 9/21/18 9:02 AM, Marc Hartmayer wrote:
> Marc Hartmayer (4):
>   virdbus: Grab a ref as long as the while loop is executed
>   virdbus: Unref the D-Bus connection when closing
>   virdbus: Report a debug message that dbus_watch_handle() has failed
>   virdbus: Use the mnemonic macros for dbus_bool_t values
> 
>  src/util/virdbus.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan at redhat.com>

(series) and pushed,

John

although /me wonders what happens to @info in virDBusAddWatch when the
call to virEventAddHandle fails, dbus_watch_set_data(watch, NULL, NULL)
is called and the code returns FALSE. I assume it's leaked, different
problem though ;-)




More information about the libvir-list mailing list