[libvirt] [PATCH 0/4] Small changes to virdbus

[Marc Hartmayer]

On Wed, Sep 26, 2018 at 01:44 AM +0200, John Ferlan <jferlan at redhat.com> wrote:
> On 9/21/18 9:02 AM, Marc Hartmayer wrote:
>> Marc Hartmayer (4):
>>   virdbus: Grab a ref as long as the while loop is executed
>>   virdbus: Unref the D-Bus connection when closing
>>   virdbus: Report a debug message that dbus_watch_handle() has failed
>>   virdbus: Use the mnemonic macros for dbus_bool_t values
>>
>>  src/util/virdbus.c | 12 ++++++++----
>>  1 file changed, 8 insertions(+), 4 deletions(-)
>>
>
> Reviewed-by: John Ferlan <jferlan at redhat.com>
>
> (series) and pushed,
>
> John
>
> although /me wonders what happens to @info in virDBusAddWatch when the
> call to virEventAddHandle fails, dbus_watch_set_data(watch, NULL, NULL)
> is called and the code returns FALSE. I assume it's leaked, different

dbus_watch_set_data(…) calls the currently assigned 'free_data_function'
function for you before setting the new data
(https://dbus.freedesktop.org/doc/api/html/dbus-watch_8c_source.html#l00689). So
at least this should be fine :)

> problem though ;-)
>
--
Kind regards / Beste Grüße
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294