[libvirt] [PATCH 2/4] qemuSetupCpusetMems: Create EMULATOR thread upfront

Michal Privoznik mprivozn at redhat.com
Tue Apr 9 14:10:36 UTC 2019


This function is going to be called after fork() and before
exec() of qemu to ensure that 'strict' mode of numatune is
honored. This point is far before qemuProcessSetupEmulator() is
called and thus CGroup for EMULATOR thread does not exist yet.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/qemu/qemu_cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index 689e0839cd..2c663aca0a 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src/qemu/qemu_cgroup.c
@@ -847,7 +847,7 @@ qemuSetupCpusetMems(virDomainObjPtr vm)
 
     if (mem_mask)
         if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
-                               false, &cgroup_temp) < 0 ||
+                               true, &cgroup_temp) < 0 ||
             virCgroupSetCpusetMems(cgroup_temp, mem_mask) < 0)
             goto cleanup;
 
-- 
2.21.0




More information about the libvir-list mailing list