[libvirt] [PATCH 0/3] qemu: monitor: detect more snapshot errors

Cole Robinson crobinso at redhat.com
Wed Apr 10 18:29:34 UTC 2019


qemu in Fedora 30 rejects migration if the VM has nested VMX
configured. This means managedsave and snapshots are rejected too.
Unfortunately the scraping we need to resort to with the text monitor
snapshot commands is not detecting that 'savevm' actually failed, so
the snapshot appears to succeed.

https://bugzilla.redhat.com/show_bug.cgi?id=1697997

qemu 4.0.0 will add an 'Error: ' prefix to most hmp command errors
(qemu commit 66363e9a43f), let's use that to detect error as well

Cole Robinson (3):
  qemu: monitor: cleanup loadvm error handling
  qemu: monitor cleanup delvm error handling
  qemu: monitor: check for common 'Error: ' string

 src/qemu/qemu_monitor_text.c | 39 ++++++++++++++++++------------------
 1 file changed, 20 insertions(+), 19 deletions(-)

-- 
2.21.0




More information about the libvir-list mailing list