[libvirt] [PATCH 1/4] src: Check for virDomainDiskInsert() retval properly

Peter Krempa pkrempa at redhat.com
Fri Apr 26 14:11:56 UTC 2019


On Fri, Apr 26, 2019 at 15:52:20 +0200, Michal Privoznik wrote:
> Our coding style specifies that only negative values are considered as
> error. Check for return value of virDomainDiskInsert() properly,
> following the style. Not that the function can now return anything other
> than 0 or -1, but it just triggers my OCD.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/libxl/libxl_driver.c | 2 +-
>  src/lxc/lxc_driver.c     | 2 +-
>  src/qemu/qemu_driver.c   | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190426/76f40466/attachment-0001.sig>


More information about the libvir-list mailing list