[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] docs: Adding 'xres' and 'yres' into qxl XML definition



On Sun, Aug 04, 2019 at 10:21:18PM -0300, jcfaracco gmail com wrote:
> From: Julio Faracco <jcfaracco gmail com>
>
> This commit adds 'xres' and 'yres' into qxl XML Domain group definition.
> Both, properties were added into properties group inside qxl model and
> they are set as optional.
>
> Signed-off-by: Julio Faracco <jcfaracco gmail com>
> ---
>  docs/schemas/domaincommon.rng | 10 ++++++++++
>  1 file changed, 10 insertions(+)

Changes to the HTML docs are missing.

>
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index a0771da45b..8d95948595 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -3606,6 +3606,16 @@
>                    <ref name="unsignedInt"/>
>                  </attribute>
>                </optional>
> +              <optional>
> +                <attribute name="xres">
> +                  <ref name="unsignedInt"/>
> +                </attribute>
> +              </optional>
> +              <optional>
> +                <attribute name="yres">
> +                  <ref name="unsignedInt"/>
> +                </attribute>
> +              </optional>

Both attributes should be enclosed by a single <optional> element, there's IMO
no compelling reason to allow usage and therefore validation of one without the
other, is there?

Erik


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]