[libvirt] [PATCH 3/4] qemu: Generate 'xres' and 'yres' for qxl device.

Erik Skultety eskultet at redhat.com
Mon Aug 5 06:43:14 UTC 2019


On Sun, Aug 04, 2019 at 10:21:20PM -0300, jcfaracco at gmail.com wrote:
> From: Julio Faracco <jcfaracco at gmail.com>
>
> Now, QEMU command line can define 'xres' and 'yres' if XML contains both
> properties from qxl model.
>
> Signed-off-by: Julio Faracco <jcfaracco at gmail.com>
> ---
>  src/qemu/qemu_command.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index fee51158a9..82430e7e98 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -4713,6 +4713,10 @@ qemuBuildDeviceVideoStr(const virDomainDef *def,
>              if (video->heads)
>                  virBufferAsprintf(&buf, ",max_outputs=%u", video->heads);
>          }
> +
> +        if (video->xres && video->yres)
> +            virBufferAsprintf(&buf, ",xres=%u,yres=%u", video->xres, video->yres);

Capabilities changes are needed. The support for specifying video resolution
was added in qemu 2.10.0, libvirt supports as old as 1.5.0. Unfortunately,
device properties listing isn't QAPIfied yet, so we can't probe this properly.

Erik




More information about the libvir-list mailing list