[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] qemu: Generate 'xres' and 'yres' for qxl device.

On Mon, Aug 05, 2019 at 08:43:14AM +0200, Erik Skultety wrote:
On Sun, Aug 04, 2019 at 10:21:20PM -0300, jcfaracco gmail com wrote:
From: Julio Faracco <jcfaracco gmail com>

Now, QEMU command line can define 'xres' and 'yres' if XML contains both
properties from qxl model.

Signed-off-by: Julio Faracco <jcfaracco gmail com>
 src/qemu/qemu_command.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index fee51158a9..82430e7e98 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -4713,6 +4713,10 @@ qemuBuildDeviceVideoStr(const virDomainDef *def,
             if (video->heads)
                 virBufferAsprintf(&buf, ",max_outputs=%u", video->heads);
+        if (video->xres && video->yres)
+            virBufferAsprintf(&buf, ",xres=%u,yres=%u", video->xres, video->yres);

Capabilities changes are needed. The support for specifying video resolution
was added in qemu 2.10.0, libvirt supports as old as 1.5.0. Unfortunately,
device properties listing isn't QAPIfied yet, so we can't probe this properly.

Not sure how QAPI comes into play here, but we already do probe for
qxl's other properties and git grep "xres" tests does show hits from
replies files from 2.10.0 on.



libvir-list mailing list
libvir-list redhat com

Attachment: signature.asc
Description: PGP signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]