[libvirt] [PATCH] build: Solve mingw build clash with DATADIR

Michal Privoznik mprivozn at redhat.com
Wed Aug 7 14:59:28 UTC 2019


On 7/31/19 9:30 PM, Eric Blake wrote:
> Commit fed58d83 was a hack to fix a mingw build failure due to header
> inclusion order resulting in a clash over the use of DATADIR, by
> repeating a trick made several other times in the past of tweaking
> inclusion order until it goes away.  Better is to revert that, and
> instead use pragmas to avoid the clash in the first place, regardless
> of header ordering, solving it for everyone in the future.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
> 
> I tested that both gcc and clang on F29 support this; but it will take
> a full CI run to see if everywhere else is okay with it. Thus, it is
> not 5.6 material.
> 
>   src/util/viratomic.h       | 3 +++
>   src/conf/checkpoint_conf.c | 2 --
>   2 files changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal




More information about the libvir-list mailing list