[libvirt] [PATCH v4 15/42] build: don't hardcode /etc in the config related files

Andrea Bolognani abologna at redhat.com
Thu Aug 8 15:25:25 UTC 2019


On Thu, 2019-08-08 at 16:10 +0100, Daniel P. Berrangé wrote:
> +++ b/src/remote/libvirtd.conf.in
>  # Use of TLS requires that x509 certificates be issued. The default locations
>  # for the certificate files is as follows:
>  #
> -#   /etc/pki/CA/cacert.pem                 - The CA master certificate
> -#   /etc/pki/libvirt/servercert.pem        - The server certificate signed with
> -#                                            the cacert.pem
> -#   /etc/pki/libvirt/private/serverkey.pem - The server private key
> +#   @sysconfdir@/pki/CA/cacert.pem - The CA master certificate
> +#   @sysconfdir@/pki/libvirt/servercert.pem - The server certificate signed with
> +#   the cacert.pem

Absolute nit: I'd leave the description in a single line, which will
then end up being shorter than 80 columns anyway in most cases, or at
least indent the second line by 4 or more spaces just to make sure
the path itself doesn't disappear in the noise.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list