[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 20/42] remote: introduce virtproxyd daemon to handle IP connectivity



On Thu, 2019-08-08 at 16:10 +0100, Daniel P. Berrangé wrote:
> +++ b/src/remote/remote_daemon.c
> @@ -906,9 +912,9 @@ daemonUsage(const char *argv0, bool privileged)
>          { "-h | --help", N_("Display program help") },
>          { "-v | --verbose", N_("Verbose messages") },
>          { "-d | --daemon", N_("Run as a daemon & write PID file") },
> -#ifdef WITH_IP
> +#if defined(WITH_IP) && defined(LIBVIRTD)
>          { "-l | --listen", N_("Listen for TCP/IP connections") },
> -#endif /* !WITH_IP */
> +#endif /* !WITH_IP && !LIBVIRTD */

Nit: the comment should read

  /* ! (WITH_IP && LIBVIRTD) */

More instances of the same later.


With that fixed,

  Reviewed-by: Andrea Bolognani <abologna redhat com>

which I apparently forgot to give the last time around.

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]