[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] nss: Don't stop parsing on unexpected key



On Fri, Aug 09, 2019 at 10:49:09AM +0200, Michal Privoznik wrote:
> Due to latest rewrite of NSS module, we are doing yajl parsing
> ourselves. This means, we had to introduce couple of callback
> that yajl calls. According to its documentation, a callback can
> cancel parsing if it returns a zero value. Well, we do just that
> in the string callback (findLeasesParserString()). If the JSON
> file we are parsing contains a key that we are not interested in,
> zero is returned meaning stop all parsing. This is not correct,
> because the JSON file can contain some other keys which are not
> harmful for our address translation (e.g. 'client-id').
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  tests/nssdata/virbr1.status    | 1 +
>  tools/nss/libvirt_nss_leases.c | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange redhat com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]