[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Revert "tpm: Check TPM XML device configuration changes after edit"



On Fri, Aug 09, 2019 at 12:15:43 +0200, Ján Tomko wrote:
> Redefining a domain via virDomainDefineXML should not give different results
> based on an already existing definition.
> 
> Also, there's a crasher somewhere in the code:
> https://bugzilla.redhat.com/show_bug.cgi?id=1739338
> 
> This reverts commit 94b3aa55f83ada33a9fdda66068d58ef1a56c0a5

Right, this kind of check is only suitable for cold(un)plug.
Redefinition of the domain is only constrained by the new XML being
correct.

Reviewed-by: Jiri Denemark <jdenemar redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]