[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Revert "configure: Remove --enable-test-coverage"



On 8/8/19 6:12 PM, Jiri Denemark wrote:
This reverts commit f38d553e2d6ec2f041cb7947b5eafcdd3b26ae65.

Gnulib's make coverage (or init-coverage, build-coverage, gen-coverage)
is not a 1-1 replacement for the original configure option. Our old
--enable-test-coverage seems to be close to gnulib's make build-coverage
except gnulib runs lcov in that phase and the build actually fails for
me even before lcov is run. And since we want to be able to just build
libvirt without running lcov, I suggest reverting to our own
implementation.

Signed-off-by: Jiri Denemark <jdenemar redhat com>
---

Notes:
     I admit the best solution would be to somehow make gnulib support what
     we need (and fix the actual build), but I don't feel brave enough to do
     that. Eric? :-)
Also if we ever switch to glib and drop gnulib completely, we would need
     to reintroduce our own implementation anyway.

  Makefile.am                | 20 +++++++++++++++++---
  configure.ac               | 18 ++++++++++++++++++
  src/Makefile.am            |  3 ++-
  src/remote/Makefile.inc.am |  2 ++
  tests/Makefile.am          |  2 ++
  tools/Makefile.am          |  6 ++++++
  6 files changed, 47 insertions(+), 4 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn redhat com>

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]