[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 4/5] qemu: add support for Direct Mode for Hyper-V Synthetic timers



Ján Tomko <jtomko redhat com> writes:

> Either leave this as-is and add the new feature in a separate test,
> or you can branch the test based on QEMU versions like we do for other
> features:
>
>     DO_TEST_CAPS_VER("pv-spinlock-disabled", "2.7.0");
>     DO_TEST_CAPS_VER("pv-spinlock-disabled", "4.0.0");
>     DO_TEST_CAPS_LATEST("pv-spinlock-disabled");

I think I slightly prefer a new test: this way we can test both 

 <stimer state='on'/>

 and

 <stimer state='on'>
   <direct state='on'/>
 </stimer>

(and it makes no sense to test hv-stimer-direct for old QEMU versions
and 4.1 is "the latest" atm).

Thank you for your review, v4 is comming soon (I promise)!

-- 
Vitaly


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]