[libvirt] [PATCH] qemu: alias: Generate 'qomName' of disk with useraliases

[Ján Tomko]

On Fri, Aug 16, 2019 at 05:18:14PM +0200, Peter Krempa wrote:
>Commit fb64e176f4f forgot to delete the check that short-circuits the
>disk alias creation if the alias is already present. The side efect

effect

>of this is that the creation qomName which is necessary to be able to
>refer to disk frontends when -blockdev is used was skipped when user
>aliases are used.
>
>Fix it by deleting the check. Also prevent any potential memory leaks
>from calling this function repeatedly by creating the qomName only when
>it's not present.
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1741838
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_alias.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190819/0ec2f095/attachment-0001.sig>