[libvirt] [PATCH v4 5/8] qemu_monitor: implement query-cpu-model-comparison

[Jiri Denemark]

On Wed, Jul 17, 2019 at 10:03:26 -0400, Collin Walling wrote:
> Interfaces with QEMU to compare CPU models. The command takes two
> CPU models, A and B, that are given a model name and an optional list
> of CPU features. Through the query-cpu-model-comparison command issued
> via QMP, a result is produced that contains the comparison evaluation
> string (identical, superset, subset, incompatible) as well as a list
> of properties (aka CPU features) responsible for the subset or
> superset result.
> 
> Signed-off-by: Collin Walling <walling at linux.ibm.com>
> Reviewed-by: Daniel Henrique Barboza <danielh413 at gmail.com>
> ---
>  src/qemu/qemu_monitor.c      | 22 ++++++++++
>  src/qemu/qemu_monitor.h      |  9 +++++
>  src/qemu/qemu_monitor_json.c | 95 ++++++++++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_monitor_json.h | 10 +++++
>  4 files changed, 136 insertions(+)

Most of the comments from 2/8 are applicable here as well.

Jirka