[libvirt] [PATCH v1 07/11] virStoragePoolObjListAdd: Separate out definition assignment

Michal Privoznik mprivozn at redhat.com
Tue Aug 20 14:33:48 UTC 2019


On 8/19/19 6:08 PM, John Ferlan wrote:

> Was it intentional to swap the order?
> 

That's a good question. Honestly, I don't recall. I'll fix it in my 
local branch. It looks like we should set the new pool definition with 
the pool list locked so that virStoragePoolObjIsDuplicate() and
virStoragePoolObjSourceFindDuplicate() can return expected value if two 
threads were fighting.

Michal




More information about the libvir-list mailing list