[libvirt] [PATCH 0/6] Honour use of /run instead of /var/run on distros

Daniel P. Berrangé berrange at redhat.com
Wed Aug 21 11:50:05 UTC 2019


Distros using systemd all use /run instead of /var/run. Libvirt has not
adapted, relying on the symlink between the two for compat. This is an
issue for UNIX sockets though, as systemd rewrites /var/run to /run
before binding to a socket and this means libvirtd cannot identify
sockets it is passed with old systemd.

Daniel P. Berrangé (6):
  build: use $(COMMON_UNIT_VARS) for logging/locking systemd units
  systemd: honour $runstatedir in socket unit files
  build: honour $(runstatedir) in make rules
  src: honour the RUNSTATEDIR variable in all code
  build: support customization of runstatedir variable with old autoconf
  rpm: set runstatedir to /run directory

 configure.ac                            | 23 +++++++++++++++++
 libvirt.spec.in                         | 15 +++++------
 src/Makefile.am                         |  2 +-
 src/bhyve/bhyve_utils.h                 |  2 +-
 src/interface/interface_backend_netcf.c |  2 +-
 src/interface/interface_backend_udev.c  |  2 +-
 src/libvirt-admin.c                     |  2 +-
 src/libxl/Makefile.inc.am               |  4 +--
 src/libxl/libxl_conf.h                  |  2 +-
 src/locking/Makefile.inc.am             | 20 ++++-----------
 src/locking/lock_daemon.c               | 18 +++++++-------
 src/locking/lock_driver_lockd.c         |  2 +-
 src/locking/virtlockd-admin.socket.in   |  2 +-
 src/locking/virtlockd.pod               |  8 +++---
 src/locking/virtlockd.socket.in         |  2 +-
 src/logging/Makefile.inc.am             | 16 +++---------
 src/logging/log_daemon.c                | 18 +++++++-------
 src/logging/log_manager.c               |  2 +-
 src/logging/virtlogd-admin.socket.in    |  2 +-
 src/logging/virtlogd.pod                |  8 +++---
 src/logging/virtlogd.socket.in          |  2 +-
 src/lxc/Makefile.inc.am                 |  4 +--
 src/lxc/lxc_conf.h                      |  2 +-
 src/lxc/lxc_process.c                   |  2 +-
 src/network/Makefile.inc.am             |  4 +--
 src/network/bridge_driver.c             |  4 +--
 src/network/leaseshelper.c              |  2 +-
 src/node_device/node_device_hal.c       |  2 +-
 src/node_device/node_device_udev.c      |  2 +-
 src/nwfilter/nwfilter_dhcpsnoop.c       |  4 +--
 src/nwfilter/nwfilter_driver.c          |  4 +--
 src/qemu/Makefile.inc.am                |  8 +++---
 src/qemu/qemu_conf.c                    |  4 +--
 src/remote/Makefile.inc.am              |  4 +++
 src/remote/libvirtd-admin.socket.in     |  2 +-
 src/remote/libvirtd-ro.socket.in        |  2 +-
 src/remote/libvirtd.conf.in             |  2 +-
 src/remote/libvirtd.pod                 | 10 ++++----
 src/remote/libvirtd.socket.in           |  2 +-
 src/remote/remote_daemon.c              | 24 +++++++++---------
 src/remote/remote_daemon_dispatch.c     |  4 +--
 src/remote/remote_driver.c              |  6 +++++
 src/remote/test_libvirtd.aug.in         |  2 +-
 src/secret/secret_driver.c              |  2 +-
 src/security/virt-aa-helper.c           | 20 ++++++---------
 src/storage/storage_driver.c            |  2 +-
 src/util/virhostdev.c                   |  2 +-
 src/util/virpidfile.c                   |  8 +++---
 src/util/virsystemd.c                   | 33 ++++++++++++++++---------
 src/vz/vz_driver.c                      |  2 +-
 50 files changed, 172 insertions(+), 151 deletions(-)

-- 
2.21.0




More information about the libvir-list mailing list