[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 10/11] tests: Avoid gnulib replacements in mocks



On Wed, Aug 21, 2019 at 07:13:22PM +0300, Roman Bolshakov wrote:
> gnulib headers change stat, lstat and open to replacement functions,
> even for function definitions. This effectively disables standard
> library overrides in virfilewrapper and virmockstathelpers since they
> are never reached.
> 
> Rename the functions and provide a declartion that uses correct
> assembler name for the mocks.
> 
> This fixes firmware lookup in domaincapstest on macOS.
> 
> Signed-off-by: Roman Bolshakov <r bolshakov yadro com>
> ---
>  tests/virfilewrapper.c     |  5 +++++
>  tests/virmockstathelpers.c | 10 ++++++++++
>  2 files changed, 15 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange redhat com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]