[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/9] virhostdevtest: Drop most of 'cleanup' and 'out' labels



On Mon, Aug 12, 2019 at 01:54:21PM +0200, Michal Privoznik wrote:
From: Michal Privoznik <miso privoznik gmail com>


Different e-mail.

In this test there is this macro CHECK_LIST_COUNT() which checks
if a list of PCI devices contains expected count. If it doesn't
an error is reported and 'goto cleanup' is invoked. There's no
real reason for that as even since its introduction there is no
cleanup done and all 'cleanup' labels contains nothing but
'return'.

Signed-off-by: Michal Privoznik <mprivozn redhat com>
---
tests/virhostdevtest.c | 147 ++++++++++++-----------------------------
1 file changed, 42 insertions(+), 105 deletions(-)


Reviewed-by: Ján Tomko <jtomko redhat com>

Jano

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]