[libvirt] [PATCH 5/9] virhostdevtest: Drop most of 'cleanup' and 'out' labels

Ján Tomko jtomko at redhat.com
Mon Aug 26 12:24:34 UTC 2019


On Mon, Aug 12, 2019 at 01:54:21PM +0200, Michal Privoznik wrote:
>From: Michal Privoznik <miso.privoznik at gmail.com>
>

Different e-mail.

>In this test there is this macro CHECK_LIST_COUNT() which checks
>if a list of PCI devices contains expected count. If it doesn't
>an error is reported and 'goto cleanup' is invoked. There's no
>real reason for that as even since its introduction there is no
>cleanup done and all 'cleanup' labels contains nothing but
>'return'.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> tests/virhostdevtest.c | 147 ++++++++++++-----------------------------
> 1 file changed, 42 insertions(+), 105 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190826/b8912706/attachment-0001.sig>


More information about the libvir-list mailing list