[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 09/19] qemu_command: use VIR_AUTOFREE for variables used once



On Wed, Aug 21, 2019 at 09:44:05AM +0200, Michal Privoznik wrote:
On 8/20/19 2:59 PM, Ján Tomko wrote:
Remove the VIR_FREE's from the cleanup sections.

Signed-off-by: Ján Tomko <jtomko redhat com>
---
 src/qemu/qemu_command.c | 207 +++++++++++++---------------------------
 1 file changed, 66 insertions(+), 141 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index b5448a074f..fe06867a88 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c

Missing: qemuBuildControllersByTypeCommandLine,

Dealt with in a later patch of this series.

qemuBuildSoundCommandLine

I will sent this in a followup series.

qemuBuildRNGCommandLine,

Dealt with in a later patch of this series.

qemuBuildSmbiosCommandLine


Sorry, I can't figure out how to make that function nicer with
VIR_AUTOFREE (and I was told not to combine VIR_AUTOFREE with VIR_FREE).

Jano

Maybe you are doing that (and other suggestions I have for this patch) in next patches. If so, disregard me.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]