[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 17/19] qemu_command: remove unnecessary labels and ret variables



On Wed, Aug 21, 2019 at 09:44:01AM +0200, Michal Privoznik wrote:
On 8/20/19 2:59 PM, Ján Tomko wrote:
The recent cleanups allow us to clean up the code a bit.

Signed-off-by: Ján Tomko <jtomko redhat com>
---
 src/qemu/qemu_command.c | 741 +++++++++++++++-------------------------
 1 file changed, 274 insertions(+), 467 deletions(-)

qemuBuildMemoryBackendProps
qemuBuildMemoryCellBackendStr

The ret usage there does not closely follow the usual mechanical pattern
so I sent those separately.

qemuBuildHostNetStr (if you take mu suggestion from previous patch and use VIR_AUTOUNREF() for @cfg)

Actually, doing that shows that cfg has been unused for a few years
there.
Dealt with separately.

Jano


Michal

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]