On Fri, Aug 23, 2019 at 12:51:56PM -0400, Cole Robinson wrote:
On 8/23/19 12:21 PM, Cole Robinson wrote:From: Marc-André Lureau <marcandre lureau redhat com> Accept a new attribute to specify usage of helper process, ex: <video> <model type='virtio' vhostuser='yes'/> </video>For other devices, we have <interface type='vhostuser'> <interface><driver name='vhost'/> <hostdev type='scsi_host'><source protocol='vhost'> Which is an attempt to make this more generic.
IMO using vhostuser='yes'
and is the simplest match to qemu terminology but maybe other people have stronger opinions.
Yes. This does not belong in the model - it's a backend thing. <driver name='vhost'/> sounds best to me (and similarly to what commit 175077fd707db6ad87d6e2a079e82bc290ac2421 did, we can also expose <driver name='qemu'/>) Jano
Signed-off-by: Marc-André Lureau <marcandre lureau redhat com> Signed-off-by: Cole Robinson <crobinso redhat com> --- docs/formatdomain.html.in | 6 ++++++ docs/schemas/domaincommon.rng | 11 ++++++++++- src/conf/domain_conf.c | 14 ++++++++++++++ src/conf/domain_conf.h | 1 + 4 files changed, 31 insertions(+), 1 deletion(-)
Description: PGP signature