[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 9/9] virhostdevtest: s/virReportError/fprintf/



On 8/26/19 2:38 PM, Ján Tomko wrote:
On Mon, Aug 12, 2019 at 01:54:25PM +0200, Michal Privoznik wrote:
If a test fails, it's stderr is caught in the logs. That's how
our CI works. But virReportError() is not.


Where are you missing the error message?
If you run the tested function through virTestRun, it calls
virDispatchError which should log the error reported via virReportError
to stderr

Huh, that's a good question. I don't recall now. I'll drop this patch then. Thanks for the review.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]