[libvirt] [PATCH v4 4/4] virsh: alphabetize domain commands in man page

Michal Privoznik mprivozn at redhat.com
Thu Aug 29 10:04:30 UTC 2019


On 8/27/19 10:35 PM, Jonathon Jongsma wrote:
> It appears that all commands were originally fully in alphabetical order
> but as new commands were added, they were sometimes inserted out of
> order.  Fix up all domain commands so that they're in alphabetical order
> again.
> 
> Signed-off-by: Jonathon Jongsma <jjongsma at redhat.com>
> ---
> NOTE: if this patch is too invasive, feel free to drop it. Also, the default
> diff detects too many spurious changes rather than just showing moved blocks of
> text.  I passed the '--minimal' option to diff to try to make the patch a bit
> more readable.

Huh, I find that --histogram produced shorter output which makes me 
question whether git actually spent any extra time finding the smalled 
diff possible.

> 
>   tools/virsh.pod | 1537 +++++++++++++++++++++++------------------------
>   1 file changed, 768 insertions(+), 769 deletions(-)

I've verified that this is plain code movement via comparing two sums:

1) git show -U0 | grep "^\+[^\+]" | sed "s/^\+//" | sed '/^$/d' | sort | 
md5sum

2) git show -U0 | grep "^\-[^-]" | sed "s/^\-//" | sed '/^$/d' | sort | 
md5sum

I got the same sum in both cases.

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal




More information about the libvir-list mailing list