[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 4/4] virsh: alphabetize domain commands in man page

On Tue, Aug 27, 2019 at 15:35:56 -0500, Jonathon Jongsma wrote:
> It appears that all commands were originally fully in alphabetical order
> but as new commands were added, they were sometimes inserted out of
> order.  Fix up all domain commands so that they're in alphabetical order
> again.
> Signed-off-by: Jonathon Jongsma <jjongsma redhat com>
> ---
> NOTE: if this patch is too invasive, feel free to drop it. Also, the default
> diff detects too many spurious changes rather than just showing moved blocks of
> text.  I passed the '--minimal' option to diff to try to make the patch a bit
> more readable.
>  tools/virsh.pod | 1537 +++++++++++++++++++++++------------------------
>  1 file changed, 768 insertions(+), 769 deletions(-)

I'm not entirely a fan of this as it moves commands which are
semanticaly related apart. One example is that 'resume' no longer
follows suspend.

I don't really see much value in alphabetic ordering in this case.

Attachment: signature.asc
Description: PGP signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]