[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 02/16] domain: add "vhostuser" attribute to virtio video model



Hi

On Tue, Aug 27, 2019 at 11:19 AM Ján Tomko <jtomko redhat com> wrote:
>
> On Fri, Aug 23, 2019 at 12:51:56PM -0400, Cole Robinson wrote:
> >On 8/23/19 12:21 PM, Cole Robinson wrote:
> >> From: Marc-André Lureau <marcandre lureau redhat com>
> >>
> >> Accept a new attribute to specify usage of helper process, ex:
> >>
> >>   <video>
> >>     <model type='virtio' vhostuser='yes'/>
> >>   </video>
> >>
> >
> >For other devices, we have
> >
> ><interface type='vhostuser'>
> ><interface><driver name='vhost'/>
> ><hostdev type='scsi_host'><source protocol='vhost'>
> >
> >Which is an attempt to make this more generic.
>
> >IMO using vhostuser='yes'
>
> missing verb?
>
> >and is the simplest match to qemu terminology but maybe other people
> >have stronger opinions.
>
> Yes.
>
> This does not belong in the model - it's a backend thing.
>
> <driver name='vhost'/> sounds best to me (and similarly to
> what commit 175077fd707db6ad87d6e2a079e82bc290ac2421 did,
> we can also expose <driver name='qemu'/>)

Shouldn't it be <driver name='vhost-user'/>?

('vhost' would be for a kernel backend)

>
> Jano
>
> >
> >> Signed-off-by: Marc-André Lureau <marcandre lureau redhat com>
> >> Signed-off-by: Cole Robinson <crobinso redhat com>
> >> ---
> >>  docs/formatdomain.html.in     |  6 ++++++
> >>  docs/schemas/domaincommon.rng | 11 ++++++++++-
> >>  src/conf/domain_conf.c        | 14 ++++++++++++++
> >>  src/conf/domain_conf.h        |  1 +
> >>  4 files changed, 31 insertions(+), 1 deletion(-)
> >>
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list



-- 
Marc-André Lureau


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]