[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [ocaml PATCH 4/4] build: remove the list_secrets binary on clean



On Thu, Aug 29, 2019 at 05:38:05PM +0200, Pino Toscano wrote:
> On Thursday, 29 August 2019 16:52:48 CEST Richard W.M. Jones wrote:
> > When I was trying to fix this package and do a release last week I was
> > thinking how nice it would be if it used automake (or perhaps meson)
> > and we could drop the manifest etc.  Hint hint!
> 
> Actually, I'm currently playing with dune, and I have to say it feels
> nice.  There only problematic thing is the current generated
> libvirt_c.c that includes the other C files, it does not play well with
> the automatic dependencies that dune figures out.
> 
> BTW what is MANIFEST for?  IIRC it is used in Perl modules, but not so
> much in OCaml ones?

It's used by the home-brew ‘make dist’ rule:

https://libvirt.org/git/?p=libvirt-ocaml.git;a=blob;f=Makefile.in;h=e50600a22c8a63d39438d85490b94e4a97180392;hb=HEAD#l77

AIUI with automake there would be a properly generated make dist
so the whole thing could go away.

Rich.

> > Are you able to push this to the upstream repo or do you need me to do
> > anything there?
> 
> Yup, I am -- pushed already.
> 
> Thanks,
> -- 
> Pino Toscano



-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]