[libvirt] [PATCH 2/3] tests: qemublock: Use bigger numbers as dummy capacity/physical

Ján Tomko jtomko at redhat.com
Fri Aug 30 15:48:16 UTC 2019


On Fri, Aug 30, 2019 at 05:30:35PM +0200, Christophe de Dinechin wrote:
>
>Peter Krempa writes:
>
>> Actually test that the full range is available.
>>
>[...]
>>          return -1;
>> diff --git a/tests/qemublocktestdata/imagecreate/luks-encopts.json b/tests/qemublocktestdata/imagecreate/luks-encopts.json
>> index f065ad89a7..c5ca863f5b 100644
>> --- a/tests/qemublocktestdata/imagecreate/luks-encopts.json
>> +++ b/tests/qemublocktestdata/imagecreate/luks-encopts.json
>> @@ -2,7 +2,7 @@ protocol:
>>  {
>>    "driver": "file",
>>    "filename": "/var/lib/libvirt/images/i.img",
>> -  "size": 42
>> +  "size": 4294967296
>>  }
>
>Does any of these tests actually require that much space to run?

No, parsing a four hundred byte json file does not really take much
space.

Jano

>If so, what is the impact on QE teams?
>
>--
>Cheers,
>Christophe de Dinechin (IRC c3d)
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190830/ff979803/attachment-0001.sig>


More information about the libvir-list mailing list