[libvirt] [PATCH] tests: Make check-file-access.pl accept files through argv

Daniel P. Berrangé berrange at redhat.com
Wed Dec 4 14:03:36 UTC 2019


On Wed, Dec 04, 2019 at 03:01:31PM +0100, Michal Privoznik wrote:
> The script needs two files to open:
> 
>   $(builddir)/test_file_access.txt, and
>   $(srcdir)/file_access_whitelist.txt.
> 
> However, the script is opening the files from the $CWD which
> won't work for a VPATH build. Make the script accept paths to the
> files through @ARGV and tune the Makefile.am to pass them.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  tests/Makefile.am          | 4 +++-
>  tests/check-file-access.pl | 8 ++++++--
>  2 files changed, 9 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

This matches what i've done in the next version of the python rewrite too

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list