[libvirt] [PATCH 5/8] qemu: blockjob: Allow NULL 'mirror' for block copy jobs due to migration

Eric Blake eblake at redhat.com
Fri Dec 6 23:03:33 UTC 2019


On 12/6/19 12:09 PM, Peter Krempa wrote:
> The non-shared-storage migration tracks the storage source used
> explicitly in the migration data so we must allow for processing of the
> block job which has NULL mirror as the mirror will not be populated.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_blockjob.c | 11 ++++++++---
>   1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
> index baa79ea80c..2773acc990 100644
> --- a/src/qemu/qemu_blockjob.c
> +++ b/src/qemu/qemu_blockjob.c
> @@ -1139,7 +1139,9 @@ qemuBlockJobProcessEventConcludedCopyPivot(virQEMUDriverPtr driver,
>   {
>       VIR_DEBUG("copy job '%s' on VM '%s' pivoted", job->name, vm->def->name);
> 
> -    if (!job->disk)
> +    /* mirror may be NULL for copy job corresponding to migragion */

migration (3 times)

With typos fixed,
Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list