[libvirt] [PATCH v2 20/25] qemu: Implement backup job APIs and qemu handling

[Cole Robinson]

On 12/3/19 12:17 PM, Peter Krempa wrote:
> This allows to start and manage the backup job.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  po/POTFILES.in           |   1 +
>  src/qemu/Makefile.inc.am |   2 +
>  src/qemu/qemu_backup.c   | 941 +++++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_backup.h   |  41 ++
>  src/qemu/qemu_driver.c   |  47 ++
>  5 files changed, 1032 insertions(+)
>  create mode 100644 src/qemu/qemu_backup.c
>  create mode 100644 src/qemu/qemu_backup.h
...
> +
> +static int
> +qemuBackupDiskPrepareOneStorage(virDomainObjPtr vm,
> +                                virHashTablePtr blockNamedNodeData,
> +                                struct qemuBackupDiskData *dd,
> +                                bool reuse_external)
> +{
> +    qemuDomainObjPrivatePtr priv = vm->privateData;
> +    int rc;
> +
> +    if (!reuse_external &&
> +        dd->store->type == VIR_STORAGE_TYPE_FILE &&
> +        virStorageFileSupportsCreate(dd->store)) {
> +
> +        if (virFileExists(dd->store->path)) {
> +            virReportError(VIR_ERR_INVALID_ARG,
> +                           _("store '%s' for backup of '%s' existst"),

Noticed this in testing, s/existst/exists/

- Cole