[libvirt] [PATCH 0/2] tests: VIR_TEST_REGENERATE_OUTPUT fixes

[Ján Tomko]

On Mon, Dec 09, 2019 at 09:30:08AM -0500, Cole Robinson wrote:
>First fix is straightforward, the test-wrap-argv.py path needs to
>be adjusted.
>
>Second bit fixes an issue I hit with:
>
>  VIR_TEST_REGENERATE_OUTPUT=1 ./build/tests/qemuxml2argvtest
>
>Where it reported not finding a python binary. I assume this is due
>to some preload PATH alteration, like the comment suggests, but I
>didn't investigate it.

The real reason is "python" being a symlink - virFindFileInPath
calls virFileIsExecutable which contains a check for S_ISREG.

>The patch sidesteps the issue and seems
>worth doing anyways
>
>Cole Robinson (2):
>  tests: fix REGENERATE test-wrap-argv.py usage
>  tests: use PYTHON detected from configure
>
> configure.ac      |  1 +
> tests/testutils.c | 14 ++------------
> 2 files changed, 3 insertions(+), 12 deletions(-)
>

Yay, less lines!

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191210/360de6c4/attachment-0001.sig>