[libvirt] [jenkins-ci PATCH 2/2] lcitool: Refactor Dockerfile generation

[Fabiano Fidêncio]

On Thu, Dec 12, 2019 at 3:05 PM Andrea Bolognani <abologna at redhat.com> wrote:
>
> On Thu, 2019-12-12 at 14:49 +0100, Fabiano Fidêncio wrote:
> > > +            commands.extend([
> > > +                "{package_manager} update -y",
> > > +                "{package_manager} install -y {pkgs}",
> > > +                "{package_manager} autoremove -y",
> >
> > This is going to be fun when we enable OpenSUSE support for container
> > generation. `zypper autoremove -y` is not a valid command and we'll
> > have to break this part.
>
> I already have patches for openSUSE locally - I'm actually testing
> them as we speak :)

Oh, me too. :-)

>
> > With this in mind, I'm not sure whether it'd be worth to have a proper
> > mapping of the distros and the commands they support, having Fedora /
> > CentOS as the base.
> >
> > What do you think?
> >
> > Mind, I'm not pushing for the mapping, just pointing it out. :-). I'm
> > fine with an `if os_name != "OpenSUSE": ...`
>
> Yeah, even with all this it's still kinda yucky, but much better
> than what we have now. Adding another level of mapping doesn't seem
> worth it to me, but feel free to experiment with it and send patches
> if you end up with something that improves on the status quo.

I'm fine with the status quo.

>
> --
> Andrea Bolognani / Red Hat / Virtualization
>