[libvirt] [PATCH 4/5] qemu: Reoder cleanup in qemuStateCleanup()

Daniel Henrique Barboza danielhb413 at gmail.com
Wed Dec 18 12:42:49 UTC 2019


Commit title has a typo: "Reoder" instead of "Reorder"

On 12/18/19 5:37 AM, Michal Privoznik wrote:
> This function is supposed to clean up virQEMUDriver structure and
> free individual members. However, it's doing that in random order
> which makes it hard to track which members are being freed and
> which are not. Do the free in reverse order than the structure
> definition - assuming that the most important members (like
> mutex) are declared first and freed last.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---




More information about the libvir-list mailing list