[libvirt] [PATCH] schemas: Allow additional qemu cmd line arguments/env variables and qemuCaps to be interleaved

Fabiano Fidêncio fidencio at redhat.com
Fri Dec 20 09:33:28 UTC 2019


On Fri, Dec 20, 2019 at 10:29 AM Michal Privoznik <mprivozn at redhat.com> wrote:
>
> While command line arguments are sort of positional (becasue you

becasue -> because

> have to have two entries, one for "-arg" the other for "value"),
> it doesn't really matter whether env variables come before or
> after command line arguments.
>
> And it matter even less when playing with qemu capabilities.

matter -> matters

>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>

Patch makes sense and doesn't break backward compat.
I'd take this review with a grain of salt ...

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>





More information about the libvir-list mailing list