[libvirt] [PATCH v2 1/3] qemu: add explicit flag to skip qemu caps invalidation

Michal Prívozník mprivozn at redhat.com
Fri Dec 20 19:12:49 UTC 2019


On 12/20/19 2:47 PM, Daniel P. Berrangé wrote:
> Currently if the binary path is NULL in the qemu capabilities object,
> cache invalidation is skipped. A future patch will ensure that the
> binary path is always non-NULL, so a way to explicitly skip invalidation
> is required.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  src/qemu/qemu_capabilities.c | 14 ++++++++++++++
>  src/qemu/qemu_capabilities.h |  3 +++
>  2 files changed, 17 insertions(+)
> 

> diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
> index 1b2522126c..7488b9ddb8 100644
> --- a/src/qemu/qemu_capabilities.h
> +++ b/src/qemu/qemu_capabilities.h
> @@ -545,6 +545,9 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(virQEMUCaps, virObjectUnref);
>  
>  virQEMUCapsPtr virQEMUCapsNew(void);
>  
> +void virQEMUCapsSetInvalidation(virQEMUCapsPtr qemuCaps,
> +                                bool enabled);
> +

Since this function is intended to be used from tests only, I guess it
can be moved to src/qemu/qemu_capspriv.h so we are not tempted to use it
from real code.

Michal




More information about the libvir-list mailing list