[libvirt] [go-xml PATCH 1/2] Fix virtio-s390 address lookup

Cole Robinson crobinso at redhat.com
Mon Dec 23 18:47:09 UTC 2019


On 12/23/19 5:02 AM, Daniel P. Berrangé wrote:
> On Fri, Dec 20, 2019 at 05:22:25PM -0500, Cole Robinson wrote:
>> It was comparing against spapr-vio
>>
>> Signed-off-by: Cole Robinson <crobinso at redhat.com>
>> ---
>> All this virtio-s390 stuff is kinda bogus though, because it is
>> never actually output in libvirt XML.
> 
> Hmm, I wonder what I was thinking when i added that. I guess we can
> just delete it all.
> 

There's an argument for removing virtio-s390 from libvirt entirely (not
the XML bit, but the qemu implementation) Unclear if any supported
distros even support it anymore, it's been removed from qemu for a few
years IIRC (non-ccw virtio machine type)

- Cole




More information about the libvir-list mailing list