[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v5 02/36] qemu_process: Use qemuProcessQmp prefix



On Sun, Dec 02, 2018 at 23:09:56 -0600, Chris Venteicher wrote:
> s/virQEMUCapsInitQMPCommand/qemuProcessQmp/

Please, use qemuProcessQMP prefix as suggested in my previous review.
There are several reasons for this:
    - QMP is not a word, it's the abbreviation for QEMU Monitor Protocol
    - we use QMP consistently in our code, we don't spell it as Qmp
      anywhere
    - Qmp is very ugly (might be subjective, though)

With s/Qmp/QMP/g

Reviewed-by: Jiri Denemark <jdenemar redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]