[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v5 03/36] qemu_process: Limit qemuProcessQmpNew to const input strings



On Sun, Dec 02, 2018 at 23:09:57 -0600, Chris Venteicher wrote:
> Add the const qualifier on non modified strings
> (string only copied inside qemuProcessQmpNew)
> so that const strings can be used directly in calls to
> qemuProcessQmpNew in future patches.
> 
> Signed-off-by: Chris Venteicher <cventeic redhat com>
> ---
>  src/qemu/qemu_process.c | 2 +-
>  src/qemu/qemu_process.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index 35e0c6172a..46aed4fc9c 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
> @@ -8123,7 +8123,7 @@ qemuProcessQmpFree(qemuProcessQmpPtr cmd)
>  
>  
>  qemuProcessQmpPtr
> -qemuProcessQmpNew(char *binary,
> +qemuProcessQmpNew(const char *binary,
>                    const char *libDir,
>                    uid_t runUid,
>                    gid_t runGid,
> diff --git a/src/qemu/qemu_process.h b/src/qemu/qemu_process.h
> index 67ed90ad4d..6d4fbda5fc 100644
> --- a/src/qemu/qemu_process.h
> +++ b/src/qemu/qemu_process.h
> @@ -231,7 +231,7 @@ struct _qemuProcessQmp {
>      virDomainObjPtr vm;
>  };
>  
> -qemuProcessQmpPtr qemuProcessQmpNew(char *binary,
> +qemuProcessQmpPtr qemuProcessQmpNew(const char *binary,
>                                      const char *libDir,
>                                      uid_t runUid,
>                                      gid_t runGid,

After s/Qmp/QMP/g

Reviewed-by: Jiri Denemark <jdenemar redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]