[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v5 14/36] qemu_process: Stop retaining Monitor config in qemuProcessQmp



On Sun, Dec 02, 2018 at 23:10:08 -0600, Chris Venteicher wrote:
> The monitor config data is removed from the qemuProcessQmp struct.
> 
> The monitor config data can be initialized immediately before call to
> qemuMonitorOpen and does not need to be maintained after the call
> because qemuMonitorOpen copies any strings it needs.

Yeah, I was thinking we should do this when I saw "qemu_process: Collect
monitor code in single function" patch.

Reviewed-by: Jiri Denemark <jdenemar redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]